[gnutls-dev] OpenCDK comments

[Timo Schulz]

Simon Josefsson wrote:

> Ok, I understand.  Still, the comment in keygen.c says:
> 
> /* WARNING: The key generation code is very old and probably needs
>             a lot of adjustments and changes. Please avoid it for now
>             if possible. */
> 
> That doesn't inspire confidence in the code...

And that's right. I wrote it at the begin and since then I never changed
or corrected any code. I did some cleanups and now it should produce at
least valid keys.



> Gnulib isn't an external dependency, it is included in gl/, see the
> 0.5.x branch of OpenCDK and <http://www.gnu.org/software/gnulib/>.  It

Ah, I see.


> can help with many portability problems, especially on mingw32.  It is
> good to remove vasprintf etc, but some things may still be required.

OK. I will think about it.


> No, it shouldn't be.  Perhaps the copy of OpenCDK inside GnuTLS can be
> made smaller, without e.g. the keyserver files, because those have
> caused compilation problems in the past.  I'll look into that.

That would be perfectly OK for me. We could even strip the keygen.c file
and maybe more which is not needed. IMHO we just need the code parser
code and the public key (management) related functions.


	Timo