SKS v. unknown HTTP headers (was: Re: IPv6 failover?)

Jason Harris jharris at widomaker.com
Fri Aug 5 12:33:25 CEST 2005


On Thu, Aug 04, 2005 at 07:54:09AM -0400, David Shaw wrote:
> On Thu, Aug 04, 2005 at 12:24:27AM -0400, Jason Harris wrote:

> > Thus, in reality, the "Expect: 100-continue" header appears to be confusing
> > SKS (during POSTs).
 
> Hmm.  No really good way to fix that in GPG or curl since they can't
> detect that a server is 1.0 without doing a GET first.  Curl, if I

Disregard that.

It isn't the Expect: header, it was the [s]scanf.  This patch fixes it:

diff -u -r1.5 dbserver.ml
--- dbserver.ml
+++ dbserver.ml
@@ -415,8 +415,9 @@
 	  let request = Wserver.strip request in
 	  match request with
 	      "/pks/add" ->
-		let keytext = Scanf.sscanf body "keytext=%s" (fun s -> s) in
+		let keytext = Scanf.sscanf body "keytext%s" (fun s -> s) in
 		let keytext = Wserver.decode keytext in
+		let keytext = Str.string_after keytext 1 in
 		let keys = Armor.decode_pubkey keytext in
 		plerror 3 "Handling /pks/add for %d keys" 
 		  (List.length keys); 

-- 
Jason Harris           |  NIC:  JH329, PGP:  This _is_ PGP-signed, isn't it?
jharris at widomaker.com _|_ web:  http://keyserver.kjsl.com/~jharris/
          Got photons?   (TM), (C) 2004
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 313 bytes
Desc: not available
Url : /pipermail/attachments/20050805/c3bb528c/attachment.pgp


More information about the Gnupg-users mailing list