[PATCH libgpg-error] Add support for IBM z/OS

[Sachin T]

HI Todd,

Thanks for pointing that out, understood.

I wasn’t able to use git send-email due to SMTP restrictions in my environment, so I sent the patch manually via Outlook. Unfortunately, that included some extra metadata.

I’ll make sure to strip that out and ensure plain text formatting next time.

I'll also ensure the white space issues are addressed in the next patch submission.

Best regards,
Sachin

On 10/06/25, 10:13 PM, "Todd Zullinger" <tmz at pobox.com> wrote:
Sachin T via Gnupg-devel wrote:
> Please review patch required for IBM z/OS platform.

I'm grossly unqualified to review the main goal of the
patch, but there are a few things which jumped out about the
formatting.

[...]
>>From cbea5636c31668ae238d899dfa6d1f4682704f83 Mon Sep 17 00:00:00 2001
> From: Sachin T sachin.t at ibm.com<mailto:sachin.t at ibm.com><mailto:sachin.t at ibm.com<mailto:sachin.t at ibm.com>>
> Date: Tue, 10 Jun 2025 20:14:04 +0530
> Subject: [PATCH] Add patches for IBM z/OS
>
> Signed-off-by: Sachin T sachin.t at ibm.com<mailto:sachin.t at ibm.com><mailto:sachin.t at ibm.com<mailto:sachin.t at ibm.com>>

This seems to have been copy/pasted and the mailer and/or
other app(s) handling the patch files have added an unwanted
mailto: link.

> ---
> src/Makefile.am   |  2 +-
> src/spawn-posix.c | 13 +++++++++++++
> 2 files changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/src/Makefile.am b/src/Makefile.am
> index e56bb23..7e874cf 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -275,7 +275,7 @@ errnos-sym.h: Makefile mkstrtable.awk errnos.in
>
> mkheader$(EXEEXT_FOR_BUILD): mkheader.c Makefile
>                $(CC_FOR_BUILD) $(CFLAGS_FOR_BUILD) $(LDFLAGS_FOR_BUILD) \
> -              $(CPPFLAGS_FOR_BUILD) -g -I. -I$(srcdir) -o $@ $(srcdir)/mkheader.c
> +             $(CPPFLAGS_FOR_BUILD) -g -I. -I$(srcdir) -o $@ $(srcdir)/mkheader.c $(LIBS)

This hunk appears to be whitespace damaged.  The pre and
post lines should both use tab rather than spaces for
indenting (the different amount of spacing was the first
sign of trouble).

--
Todd

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.gnupg.org/pipermail/gnupg-devel/attachments/20250612/2c646564/attachment-0001.html>