[PATCH Libgpg-error] argparse: Remove a duplicated condition.

Werner Koch wk at gnupg.org
Tue Jun 10 10:23:03 CEST 2025


On Sat,  7 Jun 2025 19:53, Collin Funk said:

>> Would "(!arg->internal || !arg->internal->confname)" be a better
>> replacement?
>
> Good questions. I did not consider that maybe that was the original
> intention when writing this...

I can't remember but I guess the idea was more my usual pattern of

      if (!arg->internal->confname || !*arg->internal->confname)
        return NULL;  /* No system conf file known.  */

and the code havin a typo.  However, at other places the code does also
not check for an empy (zero length) file name.  Thus your original patch
is okay.


Salam-Shalom,

   Werner

-- 
The pioneers of a warless world are the youth that
refuse military service.             - A. Einstein
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 247 bytes
Desc: not available
URL: <https://lists.gnupg.org/pipermail/gnupg-devel/attachments/20250610/ec21c38c/attachment.sig>


More information about the Gnupg-devel mailing list