[GPGME PATCH] core: Restore get_max_fds optimization on Linux

Daniel Kahn Gillmor dkg at fifthhorseman.net
Tue Sep 19 23:56:22 CEST 2017


On Tue 2017-09-19 11:42:22 -0400, Daniel Kahn Gillmor wrote:
> I've included this in debian for our Linux-based architectures in
> gpgme 1.9.0-5.

https://buildd.debian.org/status/fetch.php?pkg=gpgme1.0&arch=arm64&ver=1.9.0-5&stamp=1505837536&raw=0

shows that on arm64 we get this failure:

--------
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -Wcast-align -Wshadow -Wstrict-prototypes -c posix-util.c -o posix-util.o >/dev/null 2>&1
posix-io.c: In function 'get_max_fds':
posix-io.c:327:25: error: 'SYS_getdents' undeclared (first use in this function); did you mean 'SYS_getdents64'?
             r = syscall(SYS_getdents, dir_fd, dir_buf, DIR_BUF_SIZE);
                         ^~~~~~~~~~~~
                         SYS_getdents64
posix-io.c:327:25: note: each undeclared identifier is reported only once for each function it appears in
Makefile:926: recipe for target 'posix-io.lo' failed
--------

i guess arm64 is new enough that it doesn't support the 32-bit
SYS_getdents at all?

Colin, do you want to propose a change to the patch so that it'll build
on that platform?  should we just move it to getdents64 for all
platforms?

        --dkg
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: </pipermail/attachments/20170919/f8f972ba/attachment.sig>


More information about the Gnupg-devel mailing list