[LIBGPG-ERROR] Add Base64 decoder
Werner Koch
wk at gnupg.org
Tue Jan 31 10:17:04 CET 2017
On Tue, 31 Jan 2017 09:27, gniibe at fsij.org said:
> submitted yesterday. If this is OK, I also copy&modify
> gnupg/common/t-b64.c into libgpg-error.
That will be good. I have one last suggestion, though:
> diff --git a/src/gpg-error.h.in b/src/gpg-error.h.in
> +struct b64state;
> +typedef struct b64state *b64state_t;
That pollutes the names space and might clash with symbols defined by
other libraries. So what about:
--8<---------------cut here---------------start------------->8---
struct _gpgrt_b64state;
typedef struct _gpgrt_b64state *gpgrt_b64state_t;
--8<---------------cut here---------------end--------------->8---
or if you want it shorter,
--8<---------------cut here---------------start------------->8---
struct _gpgrt_b64;
typedef struct _gpgrt_b64 *gpgrt_b64_t;
--8<---------------cut here---------------end--------------->8---
might also be okay. I would prefer the first version as it is more
explicit.
Shalom-Salam,
Werner
--
Die Gedanken sind frei. Ausnahmen regelt ein Bundesgesetz.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 227 bytes
Desc: not available
URL: </pipermail/attachments/20170131/fdf57f6f/attachment.sig>
More information about the Gnupg-devel
mailing list