[PATCH] curses: remove hard-wired ncursesw include path

[Daiki Ueno]

Daniel Kahn Gillmor <dkg at fifthhorseman.net> writes:

> I ran into this on debian unstable systems.  If we revert it, i'm
> concerned that this will mean restoring the warning again; i agree with
> Gergely that pkg-config *should* do things properly and the additional
> #ifdef shouldn't be needed, but that's not what i saw happening.

I observed a couple of things:

- On Debian, pkg-config ncursesw --cflags returns:

    -D_GNU_SOURCE -I/usr/include/ -I/usr/include/ncursesw

  where the first -I is superfluous and causing the problem, as there is
  /usr/include/curses.h.  This might be a bug in ncurses upstream (I've
  reported it).

- On Fedora, /usr/include/{,ncurses/,ncursesw/}curses.h are identical
  and have the addnwstr declaration.  This is legitimate because the
  header file for the wide-character configuration is upper compatible
  with the non-wide-character version, as noted in ncurses/INSTALL.

> Maybe there's some other way to fix this cleanly?

I guess the cleaner way is either to fix the former issue (though it
might be a bit fragile to rely on the -I order), or to change the
packaging like the latter.

Regards,
-- 
Daiki  Ueno