[OT] pinentry 0.7.1 & Gtk+-2

[Albrecht Dreß]

Hi Marcus,

sorry for answering late - I returned from my holiday (*without* internet)  
only yesterday...

Am 17.08.04 20:31 schrieb(en) Marcus Brinkmann:
> Thanks for providing this patch.  I have put it into CVS now.  There

Wow, cool... thanks a lot!!

> 1. The GNU coding style should be honored, at least for our own code.
>    It doesn't make much sense for gtksecentry.{c,h}, but I changed it
>    for pinentry-gtk-2.c.  Please keep this in mind for the future.

Sorry.. I'll do that! Is "indent -gnu" sufficient, or do you recommend/ 
require additional options?

> 2. We need a clearer copyright statement from you for
[snip]
>    The simplest thing for you would be to just add yourself to the top
>    of the file, where the other authors are listed, like this:

A patch (against today's cvs) is attached. I hope it's o.k. now?

> 3. We have no copyright in padlock-keyhole.xpm.  I think you told me

Starting with gtk+ 2.4.0, this icon is now a "stock" one (and not only  
referred to in the gnome hig). So you can (should) remove the xpm file  
from the cvs, the (tiny) changes needed in the sources are again in the  
patch below.

> 4. I think we would want assignment for the changes to
>    pinentry-gtk-2.c and the configure.ac and Makefile.am files
>    (gtksecentry.{h,c} are special again).  Are you willing to do that?

Sure, if you tell me what I have to do... ;-))

Thanks, Albrecht.

-- 
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 Albrecht Dreß  -  Johanna-Kirchner-Straße 13  -  D-53123 Bonn (Germany)
       Phone (+49) 228 6199571  -  mailto:albrecht.dress at arcor.de
_________________________________________________________________________

-------------- next part --------------
A non-text attachment was scrubbed...
Name: pinentry-patch-20040901.diff.gz
Type: application/x-gzip
Size: 973 bytes
Desc: not available
Url : /pipermail/attachments/20040901/1c73d740/pinentry-patch-20040901.diff.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : /pipermail/attachments/20040901/1c73d740/attachment.bin