[PATCH] cipher:pk:sexp: Remove bogus checks in SEXP parsing.

NIIBE Yutaka gniibe at fsij.org
Tue Jun 24 08:23:01 CEST 2025


Hello, again,

I wrote:
> * cipher/pubkey-util.c (_gcry_pk_util_data_to_mpi): Remove bogus check
> for VALUELEN.

I withdraw the proposal of this patch.


Jacob Bachmeyer <jcb62281 at gmail.com> wrote:
> NACK!  NACK!  NACK!

Thank you for your feedback.

Looking the commit log and other use cases, I learned that it is the
check when we use opaque MPI; Internally, when MPI is opaque, it holds a
information of number of bits.

The check:

	8*VALUELEN < VALUELEN

detects the case where it cannot be represented by an opaque MPI.
-- 



More information about the Gcrypt-devel mailing list