[PATCH 1/1] Add SM4 symmetric cipher algorithm

[Jussi Kivilinna]

On 9.6.2020 20.59, Jussi Kivilinna wrote:
> Hello,
> 
> Patch looks mostly good. I have add few comments below.
> 
> On 8.6.2020 14.00, Tianjia Zhang via Gcrypt-devel wrote:
>> * cipher/Makefile.am (EXTRA_libcipher_la_SOURCES): Add sm4.c.
>> * cipher/cipher.c (cipher_list, cipher_list_algo301):
>> Add _gcry_cipher_spec_sm4.
>> * cipher/sm4.c: New.
>> * configure.ac (available_ciphers): Add sm4.
>> * src/cipher.h: Add declarations for SM4.
>> * src/gcrypt.h.in (gcry_cipher_algos): Add algorithm ID for SM4.
>> * tests/basic.c (check_ciphers): Add sm4 check.
> 
> Please also add GCRY_MAC_CMAC_SM4 support in mac.c/mac-cmac.c.
> 

Oh, and please add also SM4 to documentation, doc/gcrypt.texi.

-Jussi