[PATCH] Add script to run basic tests with all supported HWF combinations
Werner Koch
wk at gnupg.org
Fri Jun 23 10:00:04 CEST 2017
Hi!
I indeed think that this test is very useful.
On Sun, 18 Jun 2017 10:23, jussi.kivilinna at iki.fi said:
> +++ b/tests/basic_all_hwfeature_combinations.sh
> @@ -0,0 +1,73 @@
> +#!/bin/bash
Unfortunately we can't depend on bash. There are enough systems w/o
bash installed.
> +# For example for Windows executables: BINEXT=.exe
> +if [ "x$BINEXT" != "x" ] && [ -e "tests/version$BINEXT" ]; then
> + binext="$BINEXT"
> +else
> + binext=""
Hmmm, running the script on Windows would require the installation of a
Unix shell. That is too troublesome. With the new gcry_get_config
fucntion we can get the features form a C program and the we would only
need to fork/exec - oh well, not on Windows :-(.
tests/random also forks but skips these checks on Windows. Which it
should not. To avoid cluttering all code with a platform dependent
implemtation of a spawing function I would suggest to wait until we have
put such a function into libgpgrt (aka libgpg-error). We plan this
because we several such spawning implementations in the GnuPG stack and
libgpgrt is a common dependency of all.
If you want to push your change, I would suggest to do it as
maintainer-only tool _for now_ so that it is not run by "make check".
Salam-Shalom,
Werner
--
Die Gedanken sind frei. Ausnahmen regelt ein Bundesgesetz.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 227 bytes
Desc: not available
URL: </pipermail/attachments/20170623/984c44f9/attachment.sig>
More information about the Gcrypt-devel
mailing list