[PATCH 3/3] Disable NEON for CPUs that are known to have broken NEON implementation

Werner Koch wk at gnupg.org
Sun Nov 2 22:59:56 CET 2014


On Sun,  2 Nov 2014 17:52, jussi.kivilinna at iki.fi said:

> +  /* Find CPU version information. */
> +  for (i = 0; i < sizeof(cpu_entries) / sizeof(cpu_entries[0]); i++)

Please use 

     for (i = 0; i < DIM(cpu_entries); i++)

for easier reading.

> +  if (cpu_implementer == 0x51 &&
> +      cpu_arch == 7 &&
> +      cpu_variant == 1 &&
> +      cpu_part == 0x4d &&
> +      cpu_revision == 0)

The GNU coding standards like to have it this way:

     if (cpu_implementer == 0x51 
         && cpu_arch == 7 
         && cpu_variant == 1
         && cpu_part == 0x4d
         && cpu_revision == 0)

(I know that the first line does not align nicely but this rule is
used everywhere else and we should stick to it.)


Shalom-Salam,

   Werner


-- 
Die Gedanken sind frei.  Ausnahmen regelt ein Bundesgesetz.




More information about the Gcrypt-devel mailing list