Explicit overflow / incorrect code?

Dmitry Eremin-Solenikov dbaryshkov at gmail.com
Sun Dec 28 10:01:42 CET 2014


Hello,

2014-12-28 8:57 GMT+03:00 Joshua Rogers <honey at internot.info>:
> Hi,
>
> In /cipher/gostr3411-94.c:
>
> 310  for (i = 1; i < 32 && nblocks != 0; i++)
> 311    {
> 312      l[i] = nblocks;
>
> But in
> /cipher/gostr3411-94.c:
> 284  u32 l[8];
>
>
> I believe it should be:
> for (i = *0*; i < *8* && nblocks != 0; i++)

Not quite, thanks for noticing though. I'll send a patch shortly.

-- 
With best wishes
Dmitry



More information about the Gcrypt-devel mailing list