[PATCH] Add support for 128-bit keys in RC2

[Peter Wu]

Hi Werner,

Thanks for taking this patch.

On Tuesday 01 October 2013 13:59:08 Werner Koch wrote:
> On Thu, 26 Sep 2013 23:20, lekensteyn at gmail.com said:
> > This patch adds support for decrypting (and encrypting) using 128-bit
> > keys using the RC2 algorithm.
> 
> Actually our RC2 implementation supports any key size >= 40 bit.  I
> can't remember why I came up with the two identifiers
> 
>     GCRY_CIPHER_RFC2268_40  = 307,  /* Ron's Cipher 2 (40 bit). */
>     GCRY_CIPHER_RFC2268_128 = 308,  /* Ron's Cipher 2 (128 bit). */
> 
> and didn't implement the second one.  Actually GCRY_CIPHER_RFC2268 would
> have been sufficient because the caller may use any keylength anyway.
> 
> I added a Changelog entry and pushed it to master.

Can you also update the documentation? In doc/gcrypt.texi from line 1563 it 
says:

    Ron's Cipher 2 in the 40 and 128 bit variants.  Note, that we currently
    only support the 40 bit variant.  The identifier for 128 is reserved for
    future use. 

If keys of any length (ranging from 0 to 1024?) are allowed, it could be 
specified in there.

Regards,
Peter