[PATCH 2/2] serpent: add AVX accelerated x86-64 implementation

Jussi Kivilinna jussi.kivilinna at iki.fi
Tue May 21 15:40:24 CEST 2013


On 21.05.2013 15:59, Werner Koch wrote:
> Hi,
> 
> some comments on this pacth:
> 
>> 'serpent_avx_x86-64.lo'.
> 
> Please use serpent-avx-amd64.* for the file names.  We generally use a
> dash as word delimiter in file names.  Also we started to use amd64 for
> this architecture (mpi/amd64) and to be consistent we should keep on
> using "amd64".  You may keep the x86_64 in comments, though.

Ok, I'll use amd64 now on.

> 
> I only now noticed that I didn't caught your camellia_aesni_avx_x86-64
> from January.  I will eventually fix that file name.
>

I can send patch to do that.

>
>> +#include "selftest_help.h"
> 
> See my other mail.
> 
> I would have reworked your patch but there is a problem with the
> selftest patches we need to be address first.
> 

Ok.

-Jussi

> 
> Salam-Shalom,
> 
>    Werner
> 




More information about the Gcrypt-devel mailing list