broken sed in 1.5.1 cipher/Makefile.am

Werner Koch wk at gnupg.org
Thu Apr 18 15:28:51 CEST 2013


On Thu, 21 Mar 2013 20:11, ametzler at downhill.at.eu.org said:
> Hello,
>
> 1.5.1 has this change compared to 1.5.0:
> -o_flag_munging = sed -e 's/-O[2-9s]*/-O1/g'
> +o_flag_munging = sed -e 's/-O([2-9s]|fast)*/-O1/g'
>
> I think the changed line should read
>
> +o_flag_munging = sed -e 's/-O([2-9s]*|fast)/-O1/g'

I think the right fix is:

-o_flag_munging = sed -e 's/-O([2-9s]|fast)*/-O1/g'
+o_flag_munging = sed -e 's/-O\([2-9s][2-9s]*\)/-O1/' -e 's/-Ofast/-O1/g'

The previous fix and your fix matches on the parenthesis which is not
want we want.  The original code didn't worked either because it
transforms an -O1 into -O11.


Shalom-Salam,

   Werner

-- 
Die Gedanken sind frei.  Ausnahmen regelt ein Bundesgesetz.




More information about the Gcrypt-devel mailing list