[PATCH gpgme] qt: Fix DLL version in cmake config files

Ingo Klöcker kloecker at kde.org
Sat Jul 8 16:14:54 CEST 2023


Hi,

Good timing! Less than one day after the release of version 1.21. :-)

On Samstag, 8. Juli 2023 07:14:44 CEST Biswapriyo Nath via Gnupg-devel wrote:
> @@ -65,11 +65,11 @@ set_target_properties(QGpgme PROPERTIES
>    IMPORTED_IMPLIB_RELEASE "@resolved_libdir@/libqgpgme.dll.a"
>    INTERFACE_INCLUDE_DIRECTORIES
> "@resolved_includedir@/qgpgme;@resolved_includedir@"
> INTERFACE_LINK_LIBRARIES "Gpgmepp;Qt5::Core"
> -  IMPORTED_LOCATION "@resolved_libdir@/libqgpgme-7.dll"
> +  IMPORTED_LOCATION "@resolved_libdir@/libqgpgme-15.dll"

I think this is still wrong because it should certainly be @resolved_bindir@ 
as below because the DLL is installed in bindir.

Makes me wonder when/how IMPORTED_LOCATION is used because, apparently, we 
never had any problems linking libkleo and kleopatra against QGpgME with MinGW 
despite IMPORTED_LOCATION pointing to a not existing file.

>  list(APPEND _IMPORT_CHECK_TARGETS QGgpme )
> -list(APPEND _IMPORT_CHECK_FILES_FOR_Qgpgme
> "@resolved_libdir@/libqgpgme.dll.a" "@resolved_bindir@/libqgpgme-7.dll" )
> +list(APPEND _IMPORT_CHECK_FILES_FOR_Qgpgme
> "@resolved_libdir@/libqgpgme.dll.a" "@resolved_bindir@/libqgpgme-15.dll" )

Regards,
Ingo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.gnupg.org/pipermail/gnupg-devel/attachments/20230708/e33ab33c/attachment.sig>


More information about the Gnupg-devel mailing list